-
Notifications
You must be signed in to change notification settings - Fork 1k
Add generic F407Vx/F417Vx pinout variant #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinout is based on the F446Rx pinout, but with different peripheral mapping and extra IOs
@fpistm I see now that the F405/415V, F407/417V and F427/437V are very similar. So similar that I think they could share the same pinout variant! Here's the difference (found from diffing their PeripheralPins.c files):
I think this should be able to take into account by adding some ifdefs in the periperalPins.c file. |
After playing around with CubeMX, it seems like the F427/437 can run at 180 MHz (the others at 168 MHz), plus the F427/437 also have slightly different clock setup settings. |
Well what about the STM32F401V which exist and have less pins... |
It's also about on what pins the peripherals are routed to. I'll see what I can do. I guess I can use Arduino_Core_STM32/variants/Generic_F103Rx/PeripheralPins.c Lines 29 to 35 in 7999a46
Sounds good to me! |
Well, up to you sometimes it is too much hard to read if too many define. FYI, I have reworked src tree of the generated files to ease access. I'm also thinking about reorder ex:
But I don't know if I can achieve this due to Arduino specification... |
I've been using this for at least a month now 😉 Would be difficult to do what I do without it. OK, I see now that F429/F439 and F469/479 are also similar. Maybe I should divide this up. Especially if you're planning to group variants into folders. How about: Generic_F4x5RG |
This should not change the "problem".
|
But from my point of view, it is certainly easier if we have three separate variants instead of one giant one. If you agree with this, this PR is already ready to be merged. |
@MCUdude will you add also F407Zx with more pins available? |
@uzi18 maybe later |
Agreed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AFAIK upload.maximum_data_size=196608 is wrong here |
yep, just checked, it stuck after uploading
so additional 64K CCM block is not after main 128K block |
I think both the PRNTR board variants also make this mistake of including CCMRAM in data size. But I guess that needs a separate issue raising. |
Sorry about this. I checked the other variants I've added recently, and they do not have CCM, only this target. |
No worries. |
Pinout is based on the F446Rx pinout, but with different peripheral mapping and extra IOs
Pinout is based on the F446Rx pinout, but with different peripheral mapping and extra IOs.